Discussion:
Valgrind: r16216 - in /trunk: NEWS coregrind/m_debuginfo/readelf.c
(too old to reply)
s***@valgrind.org
2017-01-31 12:33:54 UTC
Permalink
Raw Message
Author: iraisr
Date: Tue Jan 31 12:33:54 2017
New Revision: 16216

Log:
Fix +1 error in get_elf_symbol_info() when computing value of 'hi' address for ML_(find_rx_mapping)()
Fixes BZ#375772

Modified:
trunk/NEWS
trunk/coregrind/m_debuginfo/readelf.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS (original)
+++ trunk/NEWS Tue Jan 31 12:33:54 2017
@@ -111,6 +111,8 @@
373555 Rename BBPTR to GSPTR as it denotes guest state pointer only
373938 const IRExpr arguments for matchIRExpr()
375514 valgrind_get_tls_addr() does not work in case of static TLS
+375772 +1 error in get_elf_symbol_info() when computing value of 'hi' address
+ for ML_(find_rx_mapping)()

Release 3.12.0 (20 October 2016)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Modified: trunk/coregrind/m_debuginfo/readelf.c
==============================================================================
--- trunk/coregrind/m_debuginfo/readelf.c (original)
+++ trunk/coregrind/m_debuginfo/readelf.c Tue Jan 31 12:33:54 2017
@@ -692,15 +692,15 @@
in_rx = (ML_(find_rx_mapping)(
di,
(*sym_avmas_out).main,
- (*sym_avmas_out).main + *sym_size_out) != NULL);
+ (*sym_avmas_out).main + *sym_size_out - 1) != NULL);
if (in_text)
vg_assert(in_rx);
if (!in_rx) {
TRACE_SYMTAB(
"ignore -- %#lx .. %#lx outside .text svma range %#lx .. %#lx\n",
- (*sym_avmas_out).main, (*sym_avmas_out).main + *sym_size_out,
+ (*sym_avmas_out).main, (*sym_avmas_out).main + *sym_size_out - 1,
di->text_avma,
- di->text_avma + di->text_size);
+ di->text_avma + di->text_size - 1);
return False;
}
} else {
@@ -708,7 +708,7 @@
TRACE_SYMTAB(
"ignore -- %#lx .. %#lx outside .data / .sdata / .rodata "
"/ .bss / .sbss svma ranges\n",
- (*sym_avmas_out).main, (*sym_avmas_out).main + *sym_size_out);
+ (*sym_avmas_out).main, (*sym_avmas_out).main + *sym_size_out - 1);
return False;
}
}

Loading...