Discussion:
review for bug 375772
(too old to reply)
Ivo Raisr
2017-01-31 04:12:43 UTC
Permalink
Raw Message
Please have a look at the proposed patch for bug 375772 [1]:
+1 error in get_elf_symbol_info() when computing value of 'hi' address for
ML_(find_rx_mapping)()

Kind regards,
I.

[1] https://bugs.kde.org/show_bug.cgi?id=375772
Mark Wielaard
2017-01-31 12:19:51 UTC
Permalink
Raw Message
Post by Ivo Raisr
+1 error in get_elf_symbol_info() when computing value of 'hi' address for
ML_(find_rx_mapping)()
Symbol sizes could be zero, which would cause this to make hi < lo. I
cannot immediately see if the code guards against that. Otherwise this
looks correct.

Cheers,

Mark
Ivo Raisr
2017-01-31 12:29:07 UTC
Permalink
Raw Message
Post by Mark Wielaard
Post by Ivo Raisr
+1 error in get_elf_symbol_info() when computing value of 'hi' address
for
Post by Ivo Raisr
ML_(find_rx_mapping)()
Symbol sizes could be zero, which would cause this to make hi < lo. I
cannot immediately see if the code guards against that. Otherwise this
looks correct.
Indeed, that was my worry as well. Fortunately get_elf_symbol_info() guards
against
this problem at the beginning of this function.
Thank you for looking into it, Mark!
I.

Loading...