Discussion:
Valgrind: r16249 - /trunk/coregrind/m_syswrap/syswrap-arm64-linux.c
(too old to reply)
s***@valgrind.org
2017-02-18 21:16:05 UTC
Permalink
Raw Message
Author: mjw
Date: Sat Feb 18 21:16:05 2017
New Revision: 16249

Log:
Remove arm64 specific (unused) setup_child () and assign_guest_tls ().

valgrind svn r16186 (which fixed bug #342040 and #373192) introduced a
generic linux way of handling setup_child and assign_guest_tls. So there
is no need anymore for arch specific implementations. And gcc complained
they were unused.

Modified:
trunk/coregrind/m_syswrap/syswrap-arm64-linux.c

Modified: trunk/coregrind/m_syswrap/syswrap-arm64-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-arm64-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-arm64-linux.c Sat Feb 18 21:16:05 2017
@@ -185,8 +185,6 @@
#undef __NR_EXIT

// forward declaration
-static void setup_child ( ThreadArchState*, ThreadArchState* );
-static void assign_guest_tls(ThreadId ctid, Addr tlsptr);
//ZZ static SysRes sys_set_tls ( ThreadId tid, Addr tlsptr );

/* ---------------------------------------------------------------------
@@ -199,19 +197,6 @@
{
}

-void setup_child ( /*OUT*/ ThreadArchState *child,
- /*IN*/ ThreadArchState *parent )
-{
- child->vex = parent->vex;
- child->vex_shadow1 = parent->vex_shadow1;
- child->vex_shadow2 = parent->vex_shadow2;
-}
-
-static void assign_guest_tls(ThreadId tid, Addr tlsptr)
-{
- VG_(threads)[tid].arch.vex.guest_TPIDR_EL0 = tlsptr;
-}
-
//ZZ /* Assigns tlsptr to the guest TPIDRURO.
//ZZ If needed for the specific hardware, really executes
//ZZ the set_tls syscall.

Loading...