Discussion:
Valgrind: r16366 - /trunk/coregrind/m_commandline.c
Add Reply
s***@valgrind.org
2017-05-12 01:37:33 UTC
Reply
Permalink
Raw Message
Author: iraisr
Date: Fri May 12 02:37:33 2017
New Revision: 16366

Log:
Fix build problems on Solaris and OS X.
Follow up to SVN r16364.

Modified:
trunk/coregrind/m_commandline.c

Modified: trunk/coregrind/m_commandline.c
==============================================================================
--- trunk/coregrind/m_commandline.c (original)
+++ trunk/coregrind/m_commandline.c Fri May 12 02:37:33 2017
@@ -71,7 +71,7 @@
or is world writeable (CVE-2008-4865). */
if (res == 0
&& stat_buf.uid == VG_(geteuid)()
- && (stat_buf.mode & VKI_S_IFREG)
+ && VKI_S_ISREG(stat_buf.mode)
&& !(stat_buf.mode & VKI_S_IWOTH)) {
if ( stat_buf.size > 0 ) {
f_clo = VG_(malloc)("commandline.rdv.1", stat_buf.size+1);
Rhys Kidd
2017-05-12 22:19:10 UTC
Reply
Permalink
Raw Message
Post by s***@valgrind.org
Author: iraisr
Date: Fri May 12 02:37:33 2017
New Revision: 16366
Fix build problems on Solaris and OS X.
Follow up to SVN r16364.
Confirming this fixes the build for macOS.
Post by s***@valgrind.org
trunk/coregrind/m_commandline.c
Modified: trunk/coregrind/m_commandline.c
============================================================
==================
--- trunk/coregrind/m_commandline.c (original)
+++ trunk/coregrind/m_commandline.c Fri May 12 02:37:33 2017
@@ -71,7 +71,7 @@
or is world writeable (CVE-2008-4865). */
if (res == 0
&& stat_buf.uid == VG_(geteuid)()
- && (stat_buf.mode & VKI_S_IFREG)
+ && VKI_S_ISREG(stat_buf.mode)
&& !(stat_buf.mode & VKI_S_IWOTH)) {
if ( stat_buf.size > 0 ) {
f_clo = VG_(malloc)("commandline.rdv.1", stat_buf.size+1);
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Valgrind-developers mailing list
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
Loading...