Discussion:
[Valgrind-developers] Valgrind: r16450 - in /trunk: NEWS none/tests/ppc32/test_isa_2_06_part1.c none/tests/ppc32/test_isa_2_06_part2.c none/tests/ppc32/test_isa_2_06_part3.c
s***@valgrind.org
2017-06-16 09:33:36 UTC
Permalink
Author: mjw
Date: Fri Jun 16 10:33:35 2017
New Revision: 16450

Log:
ppc64 doesn't compile test_isa_2_06_partx.c without VSX support

The #ifdef HAS_VSX guard is wrongly placed. It makes the standard
include headers not be used. Causing a build failure. Fix by moving
the #ifdef HAS_VSX after the standard includes.

https://bugs.kde.org/show_bug.cgi?id=381272

Modified:
trunk/NEWS
trunk/none/tests/ppc32/test_isa_2_06_part1.c
trunk/none/tests/ppc32/test_isa_2_06_part2.c
trunk/none/tests/ppc32/test_isa_2_06_part3.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS (original)
+++ trunk/NEWS Fri Jun 16 10:33:35 2017
@@ -37,6 +37,7 @@

380397 s390x: __GI_strcspn() replacemenet needed
381162 possible array overrun in VEX register allocator
+381272 ppc64 doesn't compile test_isa_2_06_partx.c without VSX support


Release 3.13.0 (15 June 2017)

Modified: trunk/none/tests/ppc32/test_isa_2_06_part1.c
==============================================================================
--- trunk/none/tests/ppc32/test_isa_2_06_part1.c (original)
+++ trunk/none/tests/ppc32/test_isa_2_06_part1.c Fri Jun 16 10:33:35 2017
@@ -20,13 +20,14 @@
The GNU General Public License is contained in the file COPYING.
*/

-#ifdef HAS_VSX
-
#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <malloc.h>
+
+#ifdef HAS_VSX
+
#include <altivec.h>

#ifndef __powerpc64__

Modified: trunk/none/tests/ppc32/test_isa_2_06_part2.c
==============================================================================
--- trunk/none/tests/ppc32/test_isa_2_06_part2.c (original)
+++ trunk/none/tests/ppc32/test_isa_2_06_part2.c Fri Jun 16 10:33:35 2017
@@ -20,17 +20,18 @@
The GNU General Public License is contained in the file COPYING.
*/

-#ifdef HAS_VSX
-
#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <malloc.h>
-#include <altivec.h>
#include <math.h>
#include <unistd.h> // getopt

+#ifdef HAS_VSX
+
+#include <altivec.h>
+
#ifndef __powerpc64__
typedef uint32_t HWord_t;
#else

Modified: trunk/none/tests/ppc32/test_isa_2_06_part3.c
==============================================================================
--- trunk/none/tests/ppc32/test_isa_2_06_part3.c (original)
+++ trunk/none/tests/ppc32/test_isa_2_06_part3.c Fri Jun 16 10:33:35 2017
@@ -20,17 +20,18 @@
The GNU General Public License is contained in the file COPYING.
*/

-#ifdef HAS_VSX
-
#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <malloc.h>
-#include <altivec.h>
#include <math.h>
#include <unistd.h> // getopt

+#ifdef HAS_VSX
+
+#include <altivec.h>
+
#ifndef __powerpc64__
typedef uint32_t HWord_t;
#else

Loading...